Summary

This fixes a bug where the component's initial height calculation would break if defaultValue was provided without an explicit fontSize in htmlStyle prop. The root cause was a mix of a bad initial estimate and invalid measurements caching:

During initialMeasure, missing a passed fontSize in props, meant it defaulted to 0, which caused the entire height estimate to be wrong. I fixed this by adding a fallback to the default font size, matching how EnrichedText measurements already handle it.

After initialMeasure, setValue (caused by the present defaultValue prop) is run, which tries to update the shadow node state, but stateWrapper is still null. This caused the MeasurementStore internal cache to be out of sync with the actual shadow node's state. Fixed this by providing an early return in invalidateLayout() - we don't call Measurement.store() at all, if stateWrapper is unavailable.

I've also tweaked two small things: in EnrichedTextInputShadowNode.cpp the forceHeightRecalculationCounter_ was never initialized before accessing its value, which would make it have random, garbage values. I've also adjusted the provided forceHeightRecalculationCounter to the stateWrapper, as its value was always pre-increment during invalidateLayout(). I believe it's better to have the shadow node's and component's counters' values consistent.

Sometimes the setValue's layout invalidation could run before the initialMeasure. That made the MeasurementStore cached measurements correct from the start, as after setValue runs, the actual component's size is measured, not estimated like it's the case with initialMeasure. You can see this race condition in the attached video.

Test Plan

I've provided a modified example app, so you can see the bug yourself - you can run

git checkout 212b2a3e

and then you can check out how it works after the fix

git checkout 4c478090

Screenshots / Videos

The race condition in action (stumbled across in a different app):

Compatibility

Checklist

• E2E tests are passing
• Required E2E tests have been added (if applicable)